Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events #10

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Events #10

merged 5 commits into from
Dec 11, 2023

Conversation

gvegayon
Copy link
Member

This PR changes term from "actions" to "events." In the R package, the biggest issue will be with GlobalActions. The new class in C++ is called "GlobalEvents." The R package should support both in he following way:

  • The cpp11 wrapper should call GlobalEvents and be called accordingly.
  • In the R file documenting the function, there should be something like the following:
#' @export
#' @rdname globalevents
add_globalaction <- add_globalevent

So that users' code doesn't break with this change. @derekmeyer37, start working on the update of the R package to reflect these changes. I will make sure this PR is merged after the checks are run.

@gvegayon gvegayon merged commit 9afe768 into master Dec 11, 2023
4 of 8 checks passed
@gvegayon gvegayon deleted the events branch May 2, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant